Fix enum idempotency

[Clebam]

Summary

Linked to issue : #265
Fixes the fact that enum are not idempotent

Related Issues (if any)

#265

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified.

[CLAassistant]

All committers have signed the CLA.

[jordanbreen28]

@Clebam this is great! I know this has been a pain point for some users, myself included.
Could you address the rubocop errors?
I wouldn't worry about the Metrics cops - you can disable inline or add to a .rubocop_todo.yml, whatever you prefer.

[Clebam]

Hi @jordanbreen28 , I'm a bit stuck on the last spec. I wonder if this is link to the spec itself. Do you have any insight on what this test is trying to perform ?

[jordanbreen28]

hey @Clebam - sure! So it looks like the context is getting a message it isn't expecting, which in this case is your change to check the type.
If you add an extra expectation to context here

ruby-pwsh/spec/unit/puppet/provider/dsc_base_provider/dsc_base_provider_spec.rb

Line 359 in 9721f08

expect(type).to receive(:check_schema)

it should hopefully fix the error!

[Clebam]

@jordanbreen28 I tried many things but I can't get rid of the error. I'm not that familiar with ruby so it's quite hard to grasp what is going wrong.

[jordanbreen28]

@Clebam No problem, its all good! I was just about to check this pr out and try a few things myself as you tagged me. Let me see if I can spot the problem

[jordanbreen28]

@Clebam altering the test case

ruby-pwsh/spec/unit/puppet/provider/dsc_base_provider/dsc_base_provider_spec.rb

Line 181 in 9721f08

it 'treats the manifest value as canonical' do

to the below worked for me - commit it and we will see what happens :)

            it 'treats the manifest value as canonical' do
              expect(context).to receive(:type).and_return(type)
              expect(type).to receive(:attributes).and_return({ dsc_property: { type: "Enum['Dword']" } })
              expect(canonicalized_resource.first[:dsc_property]).to eq('Dword')
            end

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9721f08) 91.83% compared to head (e2cc873) 91.96%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   91.83%   91.96%   +0.12%     
==========================================
  Files           6        6              
  Lines         698      709      +11     
==========================================
+ Hits          641      652      +11     
  Misses         57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jordanbreen28]

and we're green! Great work @Clebam and thanks for your contribution!