(CAT-1724) - Fix Provider returned data not matching Type Schema #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
cat-1724-fix_value_mismatch
branch
5 times, most recently
from
2840b84 to
7746890
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
+ Coverage 91.90% 91.98% +0.07%
==========================================
Files 6 6
Lines 704 711 +7
==========================================
+ Hits 647 654 +7
Misses 57 57 ☔ View full report in Codecov by Sentry. |
Prior to this commit, we would see the above error returned when dsc
would return a nil value for a required string in its data hash.
As puppet is not expecting a nil value, but rather an empty string, the
error is raised on each puppet run where this occurs.
We can fix this by converting all required string attributes values in
the data hash from nil to an empty string ('').
jordanbreen28
force-pushed
the
cat-1724-fix_value_mismatch
branch
from
7746890 to
e802c9a
Compare
david22swan
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this PR, we would see the above error returned when dsc would return a nil value for a required string in its data hash.
As puppet is not expecting a nil value, but rather a complete or empty string, the error is raised on each puppet run where this occurs.
We can fix this by converting all required string attributes values returned in the data hash by DSC from nil to an empty string ('').
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist