Handle string credentials #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, unit test show an issue but I can't figure out what it is. I lack knowledge with specs. If anyone could help edit: |
Clebam
force-pushed
the
Handle-string-credentials
branch
from
0c8afa1 to
845eaf1
Compare
danadoherty639
approved these changes
Mar 4, 2025
|
|
|
@danadoherty639 Hello, is it possible to create new tag with this PR ? Thanks. |
This PR has been merged so I'm not sure if a tag can be applied to it but I'll check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure Sentive[String] also accept String
(Concerns SecureString - though SecureString is never used in any resource - and PSCredential)
Additional Context
Fix this issue : #367
Related Issues (if any)
Is a requirement for : puppetlabs/Puppet.Dsc#306
#367
Checklist