Skip to content

(CAT-2281) Remove puppet 7 infrastructure #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025

Conversation

LukasAud
Copy link
Contributor

@LukasAud LukasAud commented Apr 8, 2025

Puppet 7 is EOL. Therefore, we can remove the test infrastructure for it. This commit aims to clear up any testing/config infrastructure related to Puppet 7 and, by extension, Ruby 2.7.

Puppet 7 is EOL. Therefore, we can remove the test infrastructure for it.
This commit aims to clear up any testing/config infrastructure related to
Puppet 7 and, by extension, Ruby 2.7.
@LukasAud LukasAud requested a review from a team as a code owner April 8, 2025 09:07
@LukasAud LukasAud force-pushed the CAT-2281-Remove_puppet_7_test_infrastructure branch 2 times, most recently from ee1f3e4 to a489d72 Compare April 9, 2025 15:00
@LukasAud LukasAud force-pushed the CAT-2281-Remove_puppet_7_test_infrastructure branch from b5faf96 to 0cbda5c Compare April 9, 2025 15:13
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (c5d70da) to head (020cd90).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files           6        6           
  Lines         733      733           
=======================================
  Hits          667      667           
  Misses         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jordanbreen28
Copy link
Contributor

jordanbreen28 commented Apr 10, 2025

@LukasAud 👋 just a heads up that the metadata of the module needs updated too https://github.com/puppetlabs/ruby-pwsh/blob/main/metadata.json#L81

@LukasAud LukasAud force-pushed the CAT-2281-Remove_puppet_7_test_infrastructure branch from 2c86537 to d9cba6f Compare April 10, 2025 14:15
@LukasAud LukasAud force-pushed the CAT-2281-Remove_puppet_7_test_infrastructure branch from d9cba6f to 020cd90 Compare April 11, 2025 09:49
Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavindidrichsen gavindidrichsen merged commit d7cee48 into main Apr 11, 2025
6 checks passed
@gavindidrichsen gavindidrichsen deleted the CAT-2281-Remove_puppet_7_test_infrastructure branch April 11, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants