Added fonts #92
Merged
Added fonts #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fonts from a node js package specifically https://github.com/patorjk/figlet.js. The headers in these have been cross referenced with the ones currently available with pyfiglet.__version__ '0.8.post1'. The names of the fonts have been changed to all lower case and spaces have been replaced by _ to conform to the rest of the fonts in the repo. figlet,js is currently under the MIT license https://github.com/patorjk/figlet.js/blob/master/LICENSE.txt.
Closed
|
I've considered the licensing issue of these per #89 (comment), which is now resolved, and I see you've added everything in fonts-contrib. I don't see any commercial declarations, so I think they are in the right place. Apologies for the long time it took to merge these, thanks for contributing. |
|
@pwaller No worries mate. Glad to hear that you settled the issue. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fonts from a node js package — specifically figlet.js — currently under the MIT license.
To eliminate duplicate font files the headers have been cross referenced with the ones currently available in:
The following changes to the font names have been made to conform to the rest of the fonts in the repo:
This additionally includes ansi_shadow.flf much like PR85.