-
Notifications
You must be signed in to change notification settings - Fork 1.5k
ROB: Initialize states array with an empty value #2280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… error below when states are not initialized
We should probably have a corresponding test case for this as well to ensure that it indeed does not fail. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 43 43
Lines 7650 7651 +1
Branches 1511 1511
=======================================
+ Hits 7226 7227 +1
Misses 262 262
Partials 162 162
☔ View full report in Codecov by Sentry. |
CI complains about type hints, but that is not related to my change, should I fix it?
Should be
I guess |
Co-authored-by: pubpub-zz <[email protected]>
Thank you for your contribution @alexey-v-paramonov :-) If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html |
@pubpub-zz @stefan6419846 Thank you for reviewing the changes 🙏 |
That would be awesome! Thanks! |
## What's new ### Bug Fixes (BUG) - Mediabox expansion size when applying non-right angle rotation (#2282) by @MrinalJain17 ### Robustness (ROB) - MissingWidth is IndirectObject (#2288) by @MartinThoma - Initialize states array with an empty value (#2280) by @alexey-v-paramonov ### Documentation (DOC) - Typo in example in extract-attachments.md (#2285) by @ageitgey - Add Alexey Paramonov as a contributor for #2280 by @MartinThoma ### Maintenance (MAINT) - Update sample-files by @MartinThoma [Full Changelog](3.17.0...3.17.1)
This is done to prevent dictionary key error below when states are not initialized