STY: Reorder filters in decode_stream_data #3289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use same order as they are described in the PDF specification. Plus some small changes to comments.
Use same order as they are described in the PDF specification. Plus some small changes to comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3289 +/- ##
==========================================
+ Coverage 96.69% 96.71% +0.01%
==========================================
Files 53 53
Lines 9024 9028 +4
Branches 1674 1674
==========================================
+ Hits 8726 8731 +5
- Misses 176 177 +1
+ Partials 122 120 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if decode_parms: | ||
| try: | ||
| predictor = decode_parms.get("/Predictor", 1) | ||
| except (AttributeError, TypeError): # Type Error is NullObject | ||
| pass # Usually an array with a null object was read | ||
| # predictor 1 == no predictor | ||
| # predictor == 1: no predictor |
There was a problem hiding this comment.
I think the old comment was more clear here.
pypdf/filters.py
Outdated
| @@ -152,6 +147,7 @@ def decode( | |||
| colors = cast(int, decode_parms[LZW.COLORS].get_object()) # type: ignore | |||
| except (TypeError, KeyError): | |||
| colors = 1 | |||
| DEFAULT_BITS_PER_COMPONENT = 8 | |||
There was a problem hiding this comment.
Defining this inside the method seems odd at all. I would propose making this an internal class-level constant instead.
stefan6419846
added
the
needs-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use same order as they are described in the PDF specification. Plus some small changes to comments.