Skip to content

[NETWORKX] Add MixedEdgeGraph into package #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 22, 2022
Merged

Conversation

adam2392
Copy link
Collaborator

Addresses #28

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

siebert-julien and others added 9 commits December 22, 2022 12:03
… fix node positions (py-why#26)

* updating draw() function for taking into account a graph layout and fix nodes positions while rendering
* Update contributing doc to show how to make changes
* Update examples/draw_and_compare_graphs_with_same_layout.py
* Bump abatilo/actions-poetry from 2.1.6 to 2.2.0 (py-why#27)

Bumps [abatilo/actions-poetry](https://github.com/abatilo/actions-poetry) from 2.1.6 to 2.2.0.
- [Release notes](https://github.com/abatilo/actions-poetry/releases)
- [Changelog](https://github.com/abatilo/actions-poetry/blob/master/.releaserc)
- [Commits](abatilo/actions-poetry@2.1.6...v2.2.0)

Signed-off-by: Julien Siebert <[email protected]>
Signed-off-by: Julien Siebert <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Co-authored-by: Adam Li <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #29 (ccb66f6) into main (b4bbebe) will increase coverage by 3.05%.
The diff coverage is 79.61%.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   68.99%   72.04%   +3.05%     
==========================================
  Files          14       17       +3     
  Lines         803     1159     +356     
  Branches      213      281      +68     
==========================================
+ Hits          554      835     +281     
- Misses        197      259      +62     
- Partials       52       65      +13     
Impacted Files Coverage Δ
pywhy_graphs/networkx/algorithms/causal/convert.py 27.77% <27.77%> (ø)
pywhy_graphs/array/export.py 60.54% <71.42%> (-1.10%) ⬇️
pywhy_graphs/networkx/classes/mixededge.py 79.45% <79.45%> (ø)
pywhy_graphs/algorithms/cyclic.py 91.89% <100.00%> (+0.22%) ⬆️
pywhy_graphs/algorithms/generic.py 67.59% <100.00%> (ø)
pywhy_graphs/classes/admg.py 82.92% <100.00%> (+0.42%) ⬆️
pywhy_graphs/classes/cpdag.py 73.46% <100.00%> (+0.55%) ⬆️
..._graphs/networkx/algorithms/causal/m_separation.py 100.00% <100.00%> (ø)
pywhy_graphs/viz/draw.py 34.88% <100.00%> (-1.48%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adam2392 adam2392 merged commit 5924622 into py-why:main Dec 22, 2022
@adam2392 adam2392 deleted the nx branch December 22, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants