Skip to content

Commit 8d069de

Browse files
committed
Commenting out pragmas as an experiment to reproduce previous observation.
1 parent 53ef29b commit 8d069de

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

include/pybind11/eigen.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#define PYBIND11_COMPATIBILITY_WDEPRECATED_COPY
1919
#endif
2020

21+
/*
2122
#if defined(__GNUC__)
2223
// These suppressions are needed only for certain compilers and versions of Eigen, but:
2324
// * Maintaining narrowly defined ifdefs is very complicated/expensive.
@@ -29,6 +30,7 @@
2930
# pragma GCC diagnostic ignored "-Wdeprecated-copy-dtor"
3031
#endif
3132
#endif
33+
*/
3234

3335
#include <Eigen/Core>
3436
#include <Eigen/SparseCore>
@@ -87,16 +89,20 @@ template <bool EigenRowMajor> struct EigenConformable {
8789
if (rstride < 0 || cstride < 0) {
8890
negativestrides = true;
8991
} else {
92+
/*
9093
#if defined(PYBIND11_COMPATIBILITY_WDEPRECATED_COPY)
9194
// Suppressing warning originating from Eigen header.
9295
# pragma GCC diagnostic push
9396
# pragma GCC diagnostic ignored "-Wdeprecated-copy"
9497
#endif
98+
*/
9599
stride = {EigenRowMajor ? rstride : cstride /* outer stride */,
96100
EigenRowMajor ? cstride : rstride /* inner stride */ };
101+
/*
97102
#if defined(PYBIND11_COMPATIBILITY_WDEPRECATED_COPY)
98103
# pragma GCC diagnostic pop
99104
#endif
105+
*/
100106
}
101107
}
102108
// Vector type:

0 commit comments

Comments
 (0)