Allow for inline_array specification in open_zarr through from_array_kwargs #10373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably not the best way to do this, but I figured I would start with the simplest way and go from there.
inline_array
snakes its way through the codebase all the way to _maybe_chunk where it gets resolved against from_array_kwargs; if you provide it infrom_array_kwargs
and explicitly toopen_dataset
, you get @dcherian's error message. So withopen_zarr
you can't provide it infrom_array_kwargs
since the default open_dataset value is used (False); this PR just removes it from from_array_kwargs and passes that value to open_dataset.Pros:
Cons:
open_zarr
is now the one place where you can useinline_array
infrom_array_kwargs
, which might lead to some confusion down the line.open_dataset
toopen_zarr
.So alternatively, I could modify
open_zarr
with anotherinline_array
arg.inline_array
kwarg inopen_zarr
#8095