Port Prior class from PyMC-Marketing

[williambdean]

This ports the Prior class from PyMC-Marketing to pymc_extras.

The deserialize module is coming along for the ride as well.

Closes #448

CC: @drbenvincent

TODO:

• Get rid of any PyMC-Marketing references

[williambdean]

test_prior file isn't being run? At least what the action logs are showing

[drbenvincent]

First time playing around with pymc-extras. I did:

conda env create -f conda-envs/environment-test.yml
conda activate pymc-extras-test
pytest tests/test_prior.py

and I got

=============================================================== test session starts ===============================================================
platform darwin -- Python 3.12.10, pytest-8.3.5, pluggy-1.6.0 -- /Users/benjamv/miniforge3/envs/pymc-extras-test/bin/python3.12
cachedir: .pytest_cache
rootdir: /Users/benjamv/git/pymc-extras
configfile: pyproject.toml
plugins: cov-6.1.1
collected 0 items / 2 skipped                                                                                                                     

=============================================================== 2 skipped in 35.11s ===============================================================

I'm probably doing something wrong with the environment setup?

[williambdean]

That seems to be with the preliz

pymc-extras/tests/test_prior.py

Lines 33 to 34 in 6d6ff78

	pz = pytest.importorskip("preliz")

[williambdean]

Need to

• add to docs
• install test for tests

[williambdean]

tests passing, yay!

[williambdean]

Here are the areas in the docs:
https://pymcio--470.org.readthedocs.build/projects/extras/en/470/api_reference.html#prior

[williambdean]

The init is showing up in the docs as well in a weird way
https://pymcio--470.org.readthedocs.build/projects/extras/en/470/generated/pymc_extras.prior.Prior.html#pymc_extras.prior.Prior.__init__

Might be something to do with the validate_call decorator

But also noticed some of the existing ones experience this already

[zaxtax]

@williambdean would it be possible to split out the deserialize module into its own PR for review that links to this one?

[williambdean]

Can be done

[williambdean]

@zaxtax, what aspects of it are you interested in pulling apart?

• The deserialization moduleI
• the to_dict / from_dict methods

[zaxtax]

@zaxtax, what aspects of it are you interested in pulling apart?

* The `deserialization` moduleI

* the `to_dict` / `from_dict` methods

Yep, there are also just a lot of updates to CI files and updating dependencies versions that seems not related

[williambdean]

Done with b9868bb

[zaxtax]

Looks good. I think we still want that functionality, so feel free to put it in another PR and I'll review it too!

…

On Tue, 27 May 2025, 18:06 Will Dean, ***@***.***> wrote: *williambdean* left a comment (pymc-devs/pymc-extras#470) <#470 (comment)> Done with b9868bb <b9868bb> — Reply to this email directly, view it on GitHub <#470 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACCUKT4VLC3RFSHECQ3PL3ASEOZAVCNFSM6AAAAAB4M5OY7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJTGE2DQNBUGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[williambdean]

Sounds good. I will add in another PR shortly

[williambdean]

Think there is something is wrong on readthedocs end

[juanitorduz]

As this is a port from pymc-marketing this approval means I agree with the inclusion of this to pymc-extras and the code works as expected :)

[williambdean]

Thanks for the reviews! I don't have merge access

[zaxtax]

Can you move the deserialize docs to that upcoming PR and I think we will be good to merge?

…

On Thu, 29 May 2025, 13:51 Will Dean, ***@***.***> wrote: *williambdean* left a comment (pymc-devs/pymc-extras#470) <#470 (comment)> Thanks for the reviews! I don't have merge access — Reply to this email directly, view it on GitHub <#470 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACCUKU6KXMORBHJPBDDDT3A3YE7AVCNFSM6AAAAAB4M5OY7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJZGE3DQOBUGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[williambdean]

Good catch. Removed

[zaxtax]

LGTM! Will merge tonite if no one gets to it in the next few hours

…

On Thu, 29 May 2025, 15:33 Will Dean, ***@***.***> wrote: *williambdean* left a comment (pymc-devs/pymc-extras#470) <#470 (comment)> Good catch. Removed — Reply to this email directly, view it on GitHub <#470 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACCUJZO2LPOBIKGDU2WH33A4ED3AVCNFSM6AAAAAB4M5OY7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJZGQYTIMRQGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>