Skip to content

Remove SGMCMC step method #5580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ricardoV94 opened this issue Mar 11, 2022 · 3 comments · Fixed by #5631
Closed

Remove SGMCMC step method #5580

ricardoV94 opened this issue Mar 11, 2022 · 3 comments · Fixed by #5631
Assignees
@arihantbansal
Labels
beginner friendly
Milestone
v4.0.0

Comments

@ricardoV94
Copy link
Member

As discussed in #5508
@arihantbansal
Copy link

I want to take this up!

@ricardoV94
Copy link
Member Author

I want to take this up!

Sure, go ahead

@ricardoV94 ricardoV94 added this to the v4.0.0 milestone Mar 14, 2022
@michaelosthege
Copy link
Member

@arihantbansal I don't see a PR on the issue. As per our contributing guide please don't claim an issue without following up a PR.

The SGMCMC file is causing problems with our mypy pre-commit step and the best solution to that problem is doing the removal (this issue).
Unless you can do it today I will take over, because the pre-commit problem is urgent.

@michaelosthege michaelosthege mentioned this issue Mar 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arihantbansal arihantbansal

Labels
beginner friendly
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Remove SGMCMC and fix flaky mypy results michaelosthege/pymc
3 participants
@michaelosthege @arihantbansal @ricardoV94