-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove SGMCMC and fix flaky mypy results #5631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SGMCMC and fix flaky mypy results #5631
Conversation
pymc/distributions/shape_utils.py
Outdated
@@ -618,4 +618,4 @@ def find_size( | |||
|
|||
def rv_size_is_none(size: Variable) -> bool: | |||
"""Check wether an rv size is None (ie., at.Constant([]))""" | |||
return size.type.shape == (0,) | |||
return size.type.shape == (0,) # type: ignore [attr-defined] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this should be fixed upstream, but I didn't want to put shape_utils.py
onto the list of non-passing files because for shape_utils.py
it's quite valuable to enforce mypy checks.
11eea5c
to
319ec85
Compare
Codecov Report
@@ Coverage Diff @@
## main #5631 +/- ##
==========================================
+ Coverage 87.63% 88.13% +0.49%
==========================================
Files 76 75 -1
Lines 13717 13641 -76
==========================================
+ Hits 12021 12022 +1
+ Misses 1696 1619 -77
|
@@ -26,8 +26,8 @@ repos: | |||
- types-filelock | |||
- types-setuptools | |||
- arviz | |||
- aesara==2.4.0 | |||
- aeppl==0.0.26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh great, even more places for the dependencies xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't imagine how delighted I was to learn that the greatness of YAML required me to add the dependencies in yet another place! </sarcasm>
I upgraded Aesara and aeppl in the pre-commit environment. Some changes in Aesara's type hints mandated updates here.
For
sampling_jax.py
therun_mypy.py
script will no longer treat it as an error if it unexpectedly passes. This caused some confusion before.Similarly, I removed
sgmcmc.py
which was the second file with flaky mypy results.Closes #5580