Skip to content

Use per-machine symbol_versions in policy.json #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2020

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Sep 27, 2020

The symbol versions exposed by glibc/gcc/libstdc++ are different for a single "semver" version depending on the machine running.
This commit reflects that fact by defining symbol_versions per machine.

This also aims to help automating the PEP600 transition (checking minimum common subset of symbols between distros). The fact that there were only one set of symbol versions prevented the automated check of this subset.

Things to notice:

  • I couldn't get a ppc64 (big-endian) running so using the same versions as before not to introduce a regression.
  • The json schema does not map to the json file but rather to the "loaded" json which keeps the same structure as before not to change the code in multiple places. One might argue it's not desirable and I can rework this in order not to change the schema while loading (but rather modify the code at appropriate places).

@mayeut mayeut requested a review from lkollar September 27, 2020 19:05
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #262 into master will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   90.06%   90.37%   +0.30%     
==========================================
  Files          20       20              
  Lines        1057     1049       -8     
  Branches      226      224       -2     
==========================================
- Hits          952      948       -4     
+ Misses         62       60       -2     
+ Partials       43       41       -2     
Impacted Files Coverage Δ
auditwheel/policy/__init__.py 100.00% <100.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd90dd...fcf58e0. Read the comment docs.

@mayeut mayeut mentioned this pull request Oct 24, 2020
The symbol versions exposed by glibc/gcc/libstdc++ are different for a single "semver" version depending on the machine running.
This commit reflects that fact by defining symbol_versions per machine.
@mayeut mayeut force-pushed the per-machine-policy branch from f2e1ef9 to 8390b79 Compare October 27, 2020 22:44
@mayeut mayeut merged commit cbb059d into pypa:master Oct 31, 2020
@mayeut mayeut deleted the per-machine-policy branch October 31, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants