Upgrade urllib3 to 1.26.19 #12913
Merged
Upgrade urllib3 to 1.26.19 #12913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
I did not put the extra effort into verifying whether pip is truly vulnerable to this CVE (and in what way), but from a quick grep, it does seem requests may trigger the vulnerable code flow (no idea whether pip uses requests in such a way that hits said flow). However, this is a fine upgrade regardless, so LGTM. Thanks!
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade urllib3 to 1.26.19 to remediate CVE-2024-37891