-
Notifications
You must be signed in to change notification settings - Fork 27
#65 Drop support of old PHP versions #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#65 Drop support of old PHP versions #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙂 I would like to keep builds for lowest dependencies to ensure our minimum requirements are ok. I suggest the following:
- php: 7.1
env: deps=low coverage=true
- php: 7.2
env: check_cs=true
- php: 7.3
env: deps=high coverage=true
.travis.yml
Outdated
- php: 7.1 | ||
env: deps=low check_cs=true coverage=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to not run the check_cs with the lowest dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I changed it.
For curiosity, any particular reason for not running code style check with lowest dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I probably prefer to have the latest php-cs-fixer rules 🙂
I just asked a renew of the Scrutinizer token... I think, not sure it worked. I wonder if I should not drop Scrutinizer completly as it's not really useful actually. |
Maybe we can move from Scrutinizer to coveralls if Scrutinizer was just used for code coverage |
Awesome, thank you @laurent35240 |
No description provided.