Skip to content

Revert "Fix memory leak in TiffEncode" #8992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wiredfool
Copy link
Member

This reverts commit e2e40c5.

Fixes #8954 (comment) .

Changes proposed in this pull request:

  • This reverts moving the cleanup for tiff encode into the cleanup function, as opposed to doing it in the actual encode
  • This is an intermittent issue on several of the platforms, it reasonably triggers using pytest -v --random-order Tests/test_file_libtiff.py on pypy3.10 on linux-x64
  • There's likely something else going on here, because the errors are on read and the changes are for write.

@radarhere
Copy link
Member

I've created #9002 as a possible alternative.

@wiredfool
Copy link
Member Author

I saw that, I haven't had a chance to test it yet. Probably Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants