Skip to content

chore: drop 10 years deprecated interface #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

nijel
Copy link
Member

@nijel nijel commented Jan 10, 2025

Proposed changes

I think 10 years of depreciation and getting a warning should be more than enough.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

I think 10 years of depreciation and getting a warning should be more than enough.
@nijel nijel self-assigned this Jan 10, 2025
@nijel nijel enabled auto-merge (rebase) January 10, 2025 13:44
@nijel nijel merged commit 9fe73f4 into python-social-auth:master Jan 10, 2025
11 checks passed
@nijel nijel deleted the tokens branch January 10, 2025 13:46
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.94%. Comparing base (326d4b3) to head (ac24c44).
Report is 56 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
+ Coverage   77.88%   77.94%   +0.05%     
==========================================
  Files         347      347              
  Lines       10669    10693      +24     
  Branches      504      455      -49     
==========================================
+ Hits         8310     8335      +25     
+ Misses       2200     2198       -2     
- Partials      159      160       +1     
Flag Coverage Δ
unittests 77.94% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant