-
-
Notifications
You must be signed in to change notification settings - Fork 559
Google One Tap implementation #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1015 +/- ##
==========================================
+ Coverage 77.88% 78.15% +0.26%
==========================================
Files 347 348 +1
Lines 10669 10765 +96
Branches 504 457 -47
==========================================
+ Hits 8310 8413 +103
+ Misses 2200 2192 -8
- Partials 159 160 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay at first look. Can you please add tests and documentation?
@nijel I've added some tests, because it's not on oauth flow they are a bit different. Also added docs at python-social-auth/social-docs#256 Also switched from urllib3 to requests as I've just noticed this library already depends on it and that requirement doesn't need that weird packaging library workaround. |
Merged, thanks for your contribution! |
Proposed changes
The changes adds Google One Tap as a backend
Checklist
Other information
You can test the changes with this dummy project https://github.com/kviktor/django-onetap-example
I haven't yet added tests or documentation but if the changes look okay I'll add them too.
I have 2 questions tho I'm not exactly sure about, maybe someone can help out
google.py
with catching ImportError and raising an exception if the library is missing in the class)Docs at python-social-auth/social-docs#256