Switch to pyproject.toml for project metadata #951
Conversation
- import the metadata using pdm import - use importlib metadata for in-code version display
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
==========================================
+ Coverage 77.88% 77.91% +0.02%
==========================================
Files 347 347
Lines 10669 10678 +9
Branches 504 504
==========================================
+ Hits 8310 8320 +10
- Misses 2200 2201 +1
+ Partials 159 157 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
offbyone
force-pushed
the
pyproject-metadata
branch
from
87bd7b2 to
c4bdb57
Compare
for more information, see https://pre-commit.ci
This is due to gabrielfalcao/HTTPretty#484
for more information, see https://pre-commit.ci
|
@nijel would you be able to approve this to run CI please? This and my other PR should fix some issues with the build. I can narrow it down a bit, but the thing currently blocking tests is the version bounds on urlllib/httpretty, which this PR addresses (and coincidentally also modernizes the build a bit) (I don't need you to merge it, per se, although that'd also be great, mostly I want to have my CI approved so that I can make sure I am not breaking anything :) ) |
The dummy tests were failing on my non-UTC development machine, because the timestamps were generated with mktime(), which uses the locale settings from the host. Changing this to use the timezone-aware `now` sorted it.
| "pytest-cov>=2.7.1", | ||
| # pinned because of https://github.com/gabrielfalcao/HTTPretty/issues/484 | ||
| "urllib3~=2.2.0", | ||
| ] |
There was a problem hiding this comment.
I would not mind dropping it from here and supporting only PEP 735 compliant tools for development (I use uv anyway).
|
Merged, thanks for your contribution! |
allow_net_connect=Falsegabrielfalcao/HTTPretty#484