Skip to content

bpo-38456: Handle the case when there is no 'true' command #16739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2019
Merged

bpo-38456: Handle the case when there is no 'true' command #16739

merged 1 commit into from
Oct 13, 2019

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 13, 2019 •
edited by miss-islington
Loading

@pablogsal pablogsal requested a review from gpshead October 13, 2019 01:09
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Oct 13, 2019
@pablogsal pablogsal mentioned this pull request Oct 13, 2019
Merged
@pablogsal pablogsal self-assigned this Oct 13, 2019
@pablogsal
Copy link
Member Author

pablogsal commented Oct 13, 2019 •
edited
Loading

I'm going to go ahead and merge this one as is a very straightforward change to avoid a buildbot storm.

Let's remember to apply this to the possible backport to 3.8 :)

@pablogsal pablogsal merged commit 46113e0 into python:master Oct 13, 2019
@pablogsal pablogsal deleted the fix_freebsd branch October 13, 2019 01:40
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 46113e0cf32748f66cf64cd633984d143b433cd1 3.8

@gpshead
Copy link
Member

gpshead commented Oct 13, 2019

haha, thanks! I'll just include this in my 3.8 PR.

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@pablogsal
bpo-38456: Handle the case when there is no 'true' command (pythonGH-…
d4a813b 
…16739)
@gpshead gpshead mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead Awaiting requested review from gpshead

Assignees

@pablogsal pablogsal

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot