Stubs for slumber #5764
Merged
Stubs for slumber #5764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be added to |
srittau
requested changes
Jul 12, 2021
stubs/slumber/slumber/exceptions.pyi
Outdated
| @@ -0,0 +1,13 @@ | |||
| from .utils import iterator as iterator, url_join as url_join | |||
There was a problem hiding this comment.
stubgen is overzealous when creating re-exports. As these imports are not used in the stubs, they shouldn't be here. Re-exporting them is more than likely just an artifact of the implementation. Same for serialize.pyi.
There was a problem hiding this comment.
Thanks for sharing that! makes a lot of sense.
srittau
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fairly popular object-oriented interface to ReSTful APIs. It acts as a wrapper around the requests library and abstracts away the handling of URLs, serialization, and request processing.
I started with stubgen, then cleaned up to address missing functions. Testing plan is to keep an eye on CI and fix any issues that arise.
cc: @JukkaL