Skip to content

Convert Sound to Google docstrings + add cross-refs and missing annotations #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Jul 22, 2024

  • Convert arcade.sound to Google docstrings
  • Add some missing annotations
  • Include some of Xero's feedback on the sound doc being to dense
  • Cross-referencing

pushfoo added 3 commits July 22, 2024 08:15
* Focus the basics section more tightly on basics and less on theory

* Use coin sounds instead of hurt sounds to promote G-rated content

* Add centralized argument table for sound loading as prototype for playback args
* Convert to Google style docstrings

* Add heavy cross-references

* Add missing annotations
@pushfoo pushfoo changed the title Convert sound to google docstrings Convert Sound to google docstrings + add cross-refs and missing annotations Jul 22, 2024
@pushfoo pushfoo changed the title Convert Sound to google docstrings + add cross-refs and missing annotations Convert Sound to Google docstrings + add cross-refs and missing annotations Jul 22, 2024
@pushfoo pushfoo merged commit 4d17288 into development Jul 22, 2024
8 checks passed
@einarf einarf deleted the convert-sound-to-google-docstrings branch July 22, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant