[BC breaking] Simplify block size configs #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the prior nested config structure where you would have: block_sizes=[[8, 8], 8] for nested loops, and block_sizes=[64, 8] for a flattened loop. Instead, you would now have: block_sizes=[8, 8, 8], flatten_loops=[False] for nested loops, and block_sizes=[8, 8, 8] flatten_loops=[True] for a flattened loop This makes config structures more predictable and easier to work with. stack-info: PR: #127, branch: jansel/stack/23
jansel
added a commit
that referenced
this pull request
Jun 4, 2025
This removes the prior nested config structure where you would have: block_sizes=[[8, 8], 8] for nested loops, and block_sizes[64, 8] for a flattened loop. Instead, you would now have: block_sizes=[8, 8, 8], flatten_loops=[False] for nested loops, and block_sizes[8, 8, 8] flatten_loops=[True] for a flattened loop This makes config structures more predictable and easier to work with. stack-info: PR: #127, branch: jansel/stack/23
facebook-github-bot
added
the
CLA Signed
This was referenced Jun 4, 2025
jansel
added a commit
that referenced
this pull request
Jun 4, 2025
This removes the prior nested config structure where you would have: block_sizes=[[8, 8], 8] for nested loops, and block_sizes=[64, 8] for a flattened loop. Instead, you would now have: block_sizes=[8, 8, 8], flatten_loops=[False] for nested loops, and block_sizes=[8, 8, 8] flatten_loops=[True] for a flattened loop This makes config structures more predictable and easier to work with. stack-info: PR: #127, branch: jansel/stack/23
jansel
added a commit
that referenced
this pull request
Jun 4, 2025
This removes the prior nested config structure where you would have: block_sizes=[[8, 8], 8] for nested loops, and block_sizes=[64, 8] for a flattened loop. Instead, you would now have: block_sizes=[8, 8, 8], flatten_loops=[False] for nested loops, and block_sizes=[8, 8, 8] flatten_loops=[True] for a flattened loop This makes config structures more predictable and easier to work with. stack-info: PR: #127, branch: jansel/stack/23
This was referenced Jun 4, 2025
jansel
added a commit
that referenced
this pull request
Jun 4, 2025
This removes the prior nested config structure where you would have: block_sizes=[[8, 8], 8] for nested loops, and block_sizes=[64, 8] for a flattened loop. Instead, you would now have: block_sizes=[8, 8, 8], flatten_loops=[False] for nested loops, and block_sizes=[8, 8, 8] flatten_loops=[True] for a flattened loop This makes config structures more predictable and easier to work with. stack-info: PR: #127, branch: jansel/stack/23
yf225
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[BC breaking] Simplify block size configs
This removes the prior nested config structure where you would have:
block_sizes=[[8, 8], 8] for nested loops, and
block_sizes=[64, 8] for a flattened loop.
Instead, you would now have:
block_sizes=[8, 8, 8], flatten_loops=[False] for nested loops, and
block_sizes=[8, 8, 8] flatten_loops=[True] for a flattened loop
This makes config structures more predictable and easier to work with.