Skip to content

Rename block_indices to block_ids #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Rename block_indices to block_ids #135

merged 1 commit into from
Jun 5, 2025

Conversation

jansel
Copy link
Contributor

@jansel jansel commented Jun 5, 2025 •
edited
Loading

Stacked PRs:

Rename block_indices to block_ids

Some minor refactoring to make naming more consistent

@jansel
Rename block_indices to block_ids
4292d18 
Some minor refactoring to make naming more consistent

stack-info: PR: #135, branch: jansel/stack/31
jansel added a commit that referenced this pull request Jun 5, 2025
@jansel
Rename block_indices to block_ids
41c2381 
Some minor refactoring to make naming more consistent

stack-info: PR: #135, branch: jansel/stack/31
@jansel jansel force-pushed the jansel/stack/31 branch from 4b4970a to 41c2381 Compare June 5, 2025 04:05
@jansel jansel force-pushed the jansel/stack/30 branch from 07e8cd3 to e2d3127 Compare June 5, 2025 04:05
This was referenced Jun 5, 2025
Merged
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 5, 2025
@jansel jansel force-pushed the jansel/stack/30 branch from e2d3127 to 4407719 Compare June 5, 2025 04:05
jansel added a commit that referenced this pull request Jun 5, 2025
@jansel
Rename block_indices to block_ids
831b55b 
Some minor refactoring to make naming more consistent

stack-info: PR: #135, branch: jansel/stack/31
@jansel jansel force-pushed the jansel/stack/31 branch from 41c2381 to 831b55b Compare June 5, 2025 04:05
@jansel jansel changed the base branch from jansel/stack/30 to main June 5, 2025 04:08
jansel added a commit that referenced this pull request Jun 5, 2025
@jansel
Rename block_indices to block_ids
33666ca 
Some minor refactoring to make naming more consistent

stack-info: PR: #135, branch: jansel/stack/31
@jansel jansel force-pushed the jansel/stack/31 branch from 831b55b to 33666ca Compare June 5, 2025 04:08
@jansel jansel changed the base branch from main to jansel/stack/30 June 5, 2025 04:08
@jansel jansel changed the base branch from jansel/stack/30 to main June 5, 2025 04:11
jansel added a commit that referenced this pull request Jun 5, 2025
@jansel
Rename block_indices to block_ids
50c8851 
Some minor refactoring to make naming more consistent

stack-info: PR: #135, branch: jansel/stack/31
@jansel jansel force-pushed the jansel/stack/31 branch from 33666ca to 50c8851 Compare June 5, 2025 04:12
@jansel jansel changed the base branch from main to jansel/stack/30 June 5, 2025 04:12
@jansel jansel requested review from yf225 and oulgen June 5, 2025 20:44
@jansel jansel force-pushed the jansel/stack/31 branch from 50c8851 to 4292d18 Compare June 5, 2025 22:14
@jansel jansel changed the base branch from jansel/stack/30 to main June 5, 2025 22:14
@jansel jansel merged commit f6b30d1 into main Jun 5, 2025
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yf225 yf225 yf225 approved these changes

@oulgen oulgen Awaiting requested review from oulgen

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jansel @yf225 @facebook-github-bot