Skip to content

Add Pyre Pre-Commit Hook #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2025
Merged

Conversation

lolpack
Copy link
Contributor

@lolpack lolpack commented Jun 6, 2025

This tests Pyre's pre-commit hook from a forked repo as a test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 6, 2025
@lolpack
Copy link
Contributor Author

lolpack commented Jun 6, 2025

@oulgen

@oulgen oulgen self-requested a review June 6, 2025 22:06
@oulgen
Copy link
Contributor

oulgen commented Jun 6, 2025

@oulgen

thanks, kicked off the CI

@oulgen
Copy link
Contributor

oulgen commented Jun 6, 2025

@lolpack looks like the CI passed, did you try it locally as well?

is it possible to merge this change into pyre repo? it might be good to use a frozen release branch for type checker instead of main branch

@oulgen oulgen merged commit ecc7e2e into pytorch-labs:main Jun 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants