Switch build system to Hatchling which has much better Language Server support #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drisspg
added a commit
that referenced
this pull request
May 18, 2025
…r support stack-info: PR: #55, branch: drisspg/stack/4
facebook-github-bot
added
the
CLA Signed
drisspg
added a commit
that referenced
this pull request
May 18, 2025
…r support stack-info: PR: #55, branch: drisspg/stack/4
…r support stack-info: PR: #55, branch: drisspg/stack/4
jansel
approved these changes
May 18, 2025
|
@drisspg also FYI, i'm gonna setup diff train to bring helion into fbcode, so I will also write TARGETS file this week |
|
Can you also add instructions to the README.md |
|
So actually no other instructions are needed in the Readme, just install in editable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Switch build system to Hatchling which has much better Language Server support
The call into setup.py feels like overkill as well since we aren't utilizing it for any real features. With this change I finally get good intellisense. I have found hatchling to be the best build system for python only projects and it is the top of recommendations for form PyPA