Skip to content

Add env HELION_PRINT_OUTPUT_CODE=1 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

Add env HELION_PRINT_OUTPUT_CODE=1 #93

merged 1 commit into from
May 30, 2025

Conversation

jansel
Copy link
Contributor

@jansel jansel commented May 30, 2025 •
edited
Loading

@jansel
Add env HELION_PRINT_OUTPUT_CODE=1
3f41045 
stack-info: PR: #93, branch: jansel/stack/6
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 30, 2025
@jansel jansel mentioned this pull request May 30, 2025
Merged
@jansel jansel requested review from oulgen and yf225 May 30, 2025 01:41
oulgen
oulgen approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@oulgen oulgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean sure.. but why do we need this when we have HELION_LOGS doing exactly this?

@jansel jansel force-pushed the jansel/stack/6 branch 2 times, most recently from 6361e97 to f7b0e46 Compare May 30, 2025 01:53
@jansel jansel mentioned this pull request May 30, 2025
Merged
@jansel jansel changed the base branch from main to jansel/stack/8 May 30, 2025 01:54
@jansel
Copy link
Contributor Author

jansel commented May 30, 2025

HELION_LOGS prints out other stuff too and is harder to find.

@jansel jansel changed the base branch from jansel/stack/8 to main May 30, 2025 03:22
@jansel jansel merged commit 793fd64 into main May 30, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oulgen oulgen oulgen approved these changes

@yf225 yf225 yf225 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jansel @oulgen @yf225 @facebook-github-bot