Skip to content

subprocess and parallelize py tests #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

subprocess and parallelize py tests #241

wants to merge 1 commit into from

Conversation

amirafzali
Copy link
Member

@amirafzali amirafzali commented Jun 11, 2025 •
edited
Loading

Differential Revision: D76448556

  • pytest-xdist will spin up a number of processes equal to CPU count and parallelizes the tests for a nice speed increase. it should also create some isolation (previously they all shared a single process context which increases the likelihood of state leaks)
    • let's monitor this and make sure it doesn't spin up hard to debug failures
  • also setting a default timeout of 300s. don't think anything should ever take more than 5m...

@amirafzali @facebook-github-bot
subprocess and parallelize py tests
7966e4a 
Differential Revision: D76448556
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 11, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76448556

dcci
dcci approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@dcci dcci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can also remove the LC_ALL=C workaround now. But that can be done separately.

@amirafzali
Copy link
Member Author

I wonder if we can also remove the LC_ALL=C workaround now. But that can be done separately.

@malfet did we get an upstream issue to track this?

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3811b9c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcci dcci dcci approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amirafzali @facebook-github-bot @dcci