Skip to content

[FX] Changes done internally at Facebook #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2023
Merged

[FX] Changes done internally at Facebook #1625

merged 2 commits into from
Jan 31, 2023

Conversation

frank-wei
Copy link
Contributor

483102cd4151f02c2d3632e6b6df7a5e59c0d6f3 Wei Wei [email protected] [fx2trt] move acc op torch.ops._caffe2.RoIAlign to fb only
8ce94a01caa090d56adb4708452b52890160ba69 Wei Wei [email protected] [aten2trt] reshape support c13a2b67f460e4dfacad2ac2a7ac537593a1c23b wwei6 [email protected] [aten2trt] resnet18 support

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Changes done internally at Facebook
cf4b024 
483102cd4151f02c2d3632e6b6df7a5e59c0d6f3 Wei Wei <[email protected]> [fx2trt] move acc op `torch.ops._caffe2.RoIAlign` to fb only
8ce94a01caa090d56adb4708452b52890160ba69 Wei Wei <[email protected]> [aten2trt] reshape support
c13a2b67f460e4dfacad2ac2a7ac537593a1c23b wwei6 <[email protected]> [aten2trt] resnet18 support
@github-actions github-actions bot requested a review from yinghai January 28, 2023 06:26
github-actions[bot]
github-actions bot approved these changes Jan 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Jan 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@frank-wei frank-wei changed the title Changes done internally at Facebook [FX] Changes done internally at Facebook Jan 28, 2023
github-actions[bot]
github-actions bot approved these changes Jan 30, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Jan 30, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@frank-wei frank-wei marked this pull request as ready for review January 31, 2023 22:39
@frank-wei frank-wei requested a review from wushirong January 31, 2023 22:40
github-actions[bot]
github-actions bot approved these changes Jan 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jan 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Jan 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jan 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@frank-wei frank-wei merged commit 10c5fef into main Jan 31, 2023
@frank-wei frank-wei deleted the fb-sync-wwei6 branch January 31, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wushirong wushirong wushirong approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@yinghai yinghai Awaiting requested review from yinghai

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: fx fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frank-wei @wushirong @facebook-github-bot