Skip to content

fix undefined attr issue #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2023
Merged

fix undefined attr issue #1783

merged 1 commit into from
Apr 10, 2023

Conversation

bowang007
Copy link
Collaborator

@bowang007 bowang007 commented Mar 28, 2023

Description

Some undefined attribute error was observed.

This is because attr::value refers to some other symbol value in some context, which makes the node cannot find the corresponding attribute key.

Fixes #1752 , #1755

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators labels Mar 28, 2023
@github-actions github-actions bot requested a review from narendasan March 28, 2023 18:03
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 861edd0 into main Apr 10, 2023
@narendasan narendasan deleted the fix_undefined_attr branch April 10, 2023 20:16
bowang007 added a commit that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Error encountered when compiling component module of GPT2
3 participants