feat: Add ATen lowering pass system #2280

gs-olive · 2023-08-31T00:44:47Z

Description

Add documentation, testing, and lowering pass management systems for ATen lowering passes

Fixes #2272

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

[ x ] My code follows the style guidelines of this project (You can use the linters)
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas and hacks
[ x ] I have made corresponding changes to the documentation
[ x ] I have added tests to verify my fix or my feature
[ x ] New and existing unit tests pass locally with my changes
[ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

py/torch_tensorrt/dynamo/lowering/passes/__init__.py

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

examples/dynamo/dynamo_aten_lowering_passes.py

py/torch_tensorrt/dynamo/lowering/passes/__init__.py

examples/dynamo/dynamo_aten_lowering_passes.py

py/torch_tensorrt/dynamo/lowering/passes/__init__.py

examples/dynamo/dynamo_aten_lowering_passes.py

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

py/torch_tensorrt/dynamo/lowering/passes/__init__.py

py/torch_tensorrt/dynamo/lowering/passes/constant_folding.py

narendasan · 2023-09-20T21:15:46Z

py/torch_tensorrt/dynamo/lowering/passes/pass_manager.py

+        super().__init__(passes)
+
+    @classmethod
+    def build_from_passlist(


n.b. for 2.2 we could build around this method for the pipeline creation API

docsrc/contributors/writing_dynamo_aten_lowering_passes.rst

- Add documentation, testing, and lowering pass management systems for ATen lowering passes

- Improve logging and pass manager utilities - Add testing of new utilities

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

narendasan

LGTM, Can you create an issue to write an RFC for the api in 2.2?

gs-olive · 2023-09-22T16:54:22Z

Added in #2338

facebook-github-bot added the cla signed label Aug 31, 2023

github-actions bot requested a review from peri044 August 31, 2023 00:45

github-actions bot approved these changes Aug 31, 2023

View reviewed changes

gs-olive force-pushed the post_aten_passes branch from c1313ea to cc0652c Compare August 31, 2023 01:20

github-actions bot approved these changes Aug 31, 2023

View reviewed changes

gs-olive force-pushed the post_aten_passes branch from cc0652c to f9918b3 Compare August 31, 2023 01:28

github-actions bot added the component: build system Issues re: Build system label Aug 31, 2023

github-actions bot approved these changes Aug 31, 2023

View reviewed changes

gs-olive force-pushed the post_aten_passes branch from f9918b3 to 91e72fb Compare August 31, 2023 01:31

github-actions bot approved these changes Aug 31, 2023

View reviewed changes

gs-olive force-pushed the post_aten_passes branch from 91e72fb to 2ae6354 Compare August 31, 2023 01:59

github-actions bot approved these changes Aug 31, 2023

View reviewed changes

gs-olive commented Sep 1, 2023

View reviewed changes

py/torch_tensorrt/dynamo/lowering/passes/__init__.py Outdated Show resolved Hide resolved

gs-olive force-pushed the dynamo_tensor_freeze branch from 07b492b to 692921e Compare September 5, 2023 18:46

gs-olive force-pushed the post_aten_passes branch from 2ae6354 to d7d9fd5 Compare September 5, 2023 18:49

github-actions bot approved these changes Sep 5, 2023

View reviewed changes

gs-olive force-pushed the post_aten_passes branch from d7d9fd5 to 245ea94 Compare September 6, 2023 05:02

github-actions bot approved these changes Sep 6, 2023

View reviewed changes

github-actions bot approved these changes Sep 13, 2023

View reviewed changes

gs-olive requested a review from narendasan September 13, 2023 19:19

gs-olive self-assigned this Sep 13, 2023

github-actions bot approved these changes Sep 13, 2023

View reviewed changes

narendasan reviewed Sep 19, 2023

View reviewed changes

examples/dynamo/dynamo_aten_lowering_passes.py Outdated Show resolved Hide resolved

gs-olive commented Sep 19, 2023

View reviewed changes

gs-olive force-pushed the post_aten_passes branch from 90eec47 to 21129b5 Compare September 20, 2023 06:35

github-actions bot approved these changes Sep 20, 2023

View reviewed changes

gs-olive force-pushed the post_aten_passes branch from 21129b5 to 8ae4510 Compare September 20, 2023 17:31

github-actions bot approved these changes Sep 20, 2023

View reviewed changes

gs-olive requested a review from narendasan September 20, 2023 17:38

github-actions bot approved these changes Sep 20, 2023

View reviewed changes

narendasan reviewed Sep 20, 2023

View reviewed changes

gs-olive added 3 commits September 20, 2023 17:43

feat: Add ATen lowering pass system

83a290a

- Add documentation, testing, and lowering pass management systems for ATen lowering passes

feat: Refactor pass manager and utilities

1a03fc5

- Improve logging and pass manager utilities - Add testing of new utilities

fix: Address review comments and add upgrades

7fa0a0c

gs-olive force-pushed the post_aten_passes branch from 8ae4510 to 7fa0a0c Compare September 21, 2023 00:43

github-actions bot approved these changes Sep 21, 2023

View reviewed changes

gs-olive requested a review from narendasan September 21, 2023 20:56

github-actions bot approved these changes Sep 21, 2023

View reviewed changes

narendasan approved these changes Sep 22, 2023

View reviewed changes

gs-olive merged commit ff4d940 into main Sep 22, 2023

gs-olive deleted the post_aten_passes branch September 22, 2023 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add ATen lowering pass system #2280

feat: Add ATen lowering pass system #2280

gs-olive commented Aug 31, 2023 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

narendasan Sep 20, 2023

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

narendasan left a comment

gs-olive commented Sep 22, 2023

feat: Add ATen lowering pass system #2280

feat: Add ATen lowering pass system #2280

Conversation

gs-olive commented Aug 31, 2023 • edited Loading

Description

Type of change

Checklist:

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

narendasan Sep 20, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

narendasan left a comment

Choose a reason for hiding this comment

gs-olive commented Sep 22, 2023

gs-olive commented Aug 31, 2023 •

edited

Loading