fix: Address multi-GPU issue in engine deserialize #2325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: core
gs-olive
force-pushed
the
runtime_multi_gpu_fix
branch
from
4fe18df to
54af72d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
gs-olive
added
the
WIP
gs-olive
force-pushed
the
runtime_multi_gpu_fix
branch
from
54af72d to
754fd5a
Compare
gs-olive
commented
Sep 19, 2023
gs-olive
added
WIP
gs-olive
force-pushed
the
runtime_multi_gpu_fix
branch
2 times, most recently
from
42c6650 to
5a6d1e6
Compare
gs-olive
removed
the
WIP
narendasan
reviewed
Sep 25, 2023
core/runtime/runtime.cpp
Outdated
| @@ -10,6 +10,8 @@ namespace runtime { | |||
| c10::optional<RTDevice> get_most_compatible_device(const RTDevice& target_device) { | |||
| LOG_DEBUG("Target Device: " << target_device); | |||
| auto device_options = find_compatible_devices(target_device); | |||
| auto current_device = get_current_device(); | |||
There was a problem hiding this comment.
This probably has performance implications since the current_device_call has significant perf overhead
There was a problem hiding this comment.
I thought this line would only run when the engine is being instantiated on a new device and not on every inference call, unless is_switch_required is entered, but this PR ensures that would not be the case.
There was a problem hiding this comment.
Default constructor of RTDevice invalid device. Add Optional argument to get_most_compatible_device if RTDevice is missing then add get_current_device call.
- Fix issue where GPU ID of device compiled on was taking precedence over GPU ID of device in context - Add performance-considerate implementation of current device-getting
gs-olive
force-pushed
the
runtime_multi_gpu_fix
branch
from
5a6d1e6 to
3df2b65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2319
Fixes #2269
Type of change
Please delete options that are not relevant and/or add your own.
Checklist:
test_multi_gpu_serde.cpp