Skip to content

chore: cherry pick of save API #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 25, 2024
Merged

chore: cherry pick of save API #2719

merged 12 commits into from
Apr 25, 2024

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Mar 27, 2024

Description

This is a cherry pick of save API PR (#2691)

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@peri044
parent f39e89e
1387cfa 
author Dheeraj Peri <[email protected]> 1711393059 -0700
committer Dheeraj Peri <[email protected]> 1711393072 -0700

chore: minor updates

chore: Fix save failures

chore: minor fixes

chore: remove duplicate bert test case

chore: remove comments

chore: add load api

chore: minor updates

chore: minor updates

chore: minor updates

chore: more updates
@peri044 peri044 requested a review from gs-olive March 27, 2024 16:28
@github-actions github-actions bot added documentation Improvements or additions to documentation component: tests Issues re: Tests component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 27, 2024
@github-actions github-actions bot requested a review from bowang007 March 27, 2024 16:28
gs-olive
gs-olive reviewed Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! Added one question

@narendasan narendasan added the ciflow/binaries/all Build for all Python Versions label Apr 2, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 2, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@github-actions github-actions bot requested a review from narendasan April 2, 2024 21:55
@peri044 peri044 removed the ciflow/binaries/all Build for all Python Versions label Apr 17, 2024
@peri044 peri044 merged commit 574368c into main Apr 25, 2024
20 of 23 checks passed
laikhtewari pushed a commit that referenced this pull request May 24, 2024
@peri044 @laikhtewari
chore: cherry pick of save API (#2719)
ab495ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gs-olive gs-olive gs-olive left review comments

@bowang007 bowang007 Awaiting requested review from bowang007

@narendasan narendasan Awaiting requested review from narendasan

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peri044 @gs-olive @narendasan @facebook-github-bot