fix: bugs in TRT 10 upgrade #2832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: conversion
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
zewenli98
force-pushed
the
fix_trt_10_ea_upgrade_bugs
branch
from
fa01628 to
62673bd
Compare
narendasan
reviewed
May 14, 2024
| @@ -29,7 +29,7 @@ class PythonTorchTensorRTModule(Module): # type: ignore[misc] | |||
|
|
|||
| def __init__( | |||
| self, | |||
| engine: trt.ICudaEngine, | |||
| engine: trt.tensorrt.IHostMemory, | |||
There was a problem hiding this comment.
Lets use the bytes interface (may be just changing the type annotation), but we use the same thing for the C++ runtime
There was a problem hiding this comment.
Thanks. Currently, the engine actually saves serialized engine since TRT 10 changes API that uses builder.build_serialized_network. Do you recommend saving deserialized engines or serialized engines?
|
Can this be merged @zewenli98 ? If so, please raise a cherry pick to release/2.3 it it's needed |
zewenli98
added a commit
that referenced
this pull request
May 18, 2024
zewenli98
added a commit
that referenced
this pull request
May 24, 2024
laikhtewari
pushed a commit
that referenced
this pull request
May 24, 2024
zewenli98
added a commit
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bugs in TRT 10 upgrade.
Fixes #2811
Type of change
Checklist: