Skip to content

assertEquals is deprecated in TestCase in Python 3.12 #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

Fixes # (issue)
assertEquals is deprecated in TestCase in python 3.12
should use assertEqual instead

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia self-assigned this Jul 25, 2024
@lanluo-nvidia lanluo-nvidia requested a review from apbose July 25, 2024 21:06
@github-actions github-actions bot added the component: tests Issues re: Tests label Jul 25, 2024
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review July 25, 2024 21:06
@github-actions github-actions bot requested a review from narendasan July 25, 2024 21:06
@lanluo-nvidia lanluo-nvidia merged commit d73341c into release/2.4 Jul 25, 2024
60 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants