Register choose_qparams_affine_float8 as custom op #2461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2461
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 54e7649 with merge base 6dfba04 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
angelayi
added
the
topic: not user facing
jerryzh168
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
looks good to me, cc @drisspg on using empty list for per tensor quant
jerryzh168
reviewed
Jun 30, 2025
| @@ -2076,6 +2078,26 @@ def forward(self, x): | |||
| self.assertTrue(torch.ops.torchao.choose_qparams_affine.default in targets) | |||
| self.assertTrue(torch.ops.torchao.quantize_affine.default in targets) | |||
| self.assertFalse(torch.ops.aten.narrow.default in targets) | |||
|
|
|||
| def test_export_float8(self): | |||
There was a problem hiding this comment.
need this skip according to CI:
ao/test/dtypes/test_affine_quantized_float.py
Lines 74 to 76 in c2a6568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2456