Skip to content

Add all fbgemm kernel Tensors into Int4WeightOnlyConfig and Float8DynamicActivationInt4WeightConfig #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: jerryzh168/stack/9
Choose a base branch
from

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jul 2, 2025

Stacked PRs:


Add all fbgemm kernel Tensors into Int4WeightOnlyConfig and Float8DynamicActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented Jul 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2474

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 1 Unrelated Failure

As of commit 7412903 with merge base 1fd34e4 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch from a3d0835 to 4b0c7c7 Compare July 2, 2025 01:58
jerryzh168 added a commit that referenced this pull request Jul 2, 2025
…micActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2025
@jerryzh168 jerryzh168 added the topic: new feature Use this tag if this PR adds a new feature label Jul 2, 2025
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/9 to main July 2, 2025 20:35
jerryzh168 added a commit that referenced this pull request Jul 2, 2025
…micActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch from 4b0c7c7 to f5977ce Compare July 2, 2025 20:36
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/9 July 2, 2025 20:36
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/9 to main July 2, 2025 21:42
jerryzh168 added a commit that referenced this pull request Jul 2, 2025
…micActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch 2 times, most recently from 04ce2c5 to afd8703 Compare July 2, 2025 21:42
jerryzh168 added a commit that referenced this pull request Jul 2, 2025
…micActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/9 July 2, 2025 21:42
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/9 to main July 2, 2025 23:44
jerryzh168 added a commit that referenced this pull request Jul 2, 2025
…micActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch from afd8703 to ff4682e Compare July 2, 2025 23:44
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/9 July 2, 2025 23:44
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/9 to main July 3, 2025 00:09
jerryzh168 added a commit that referenced this pull request Jul 3, 2025
…micActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch from ff4682e to 58f8a2a Compare July 3, 2025 00:09
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/9 July 3, 2025 00:09
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/9 to main July 3, 2025 02:18
jerryzh168 added a commit that referenced this pull request Jul 3, 2025
…amicActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch from 58f8a2a to 532a7e1 Compare July 3, 2025 02:18
@jerryzh168 jerryzh168 changed the title Add fbgemm preshuffle kernel into Int4WeightOnlyConfig and Float8DynamicActivationInt4WeightConfig Add all fbgemm kernel Tensors into Int4WeightOnlyConfig and Float8DynamicActivationInt4WeightConfig Jul 3, 2025
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/9 July 3, 2025 02:18
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/9 to main July 3, 2025 02:23
jerryzh168 added a commit that referenced this pull request Jul 3, 2025
…amicActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch from 532a7e1 to e506cf3 Compare July 3, 2025 02:23
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/9 July 3, 2025 02:23
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/9 to main July 3, 2025 02:36
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch from e506cf3 to 708fc00 Compare July 3, 2025 02:36
jerryzh168 added a commit that referenced this pull request Jul 3, 2025
…amicActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/9 July 3, 2025 02:36
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/9 to main July 3, 2025 02:37
jerryzh168 added a commit that referenced this pull request Jul 3, 2025
…amicActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch from 708fc00 to a6b093c Compare July 3, 2025 02:38
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/9 July 3, 2025 02:38
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/9 to main July 3, 2025 02:44
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch from a6b093c to ba8cde2 Compare July 3, 2025 02:44
jerryzh168 added a commit that referenced this pull request Jul 3, 2025
…amicActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/9 July 3, 2025 02:44
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/9 to main July 3, 2025 20:58
jerryzh168 added a commit that referenced this pull request Jul 3, 2025
…amicActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch from ba8cde2 to acc33bd Compare July 3, 2025 20:58
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/9 July 3, 2025 20:58
…amicActivationInt4WeightConfig

Summary:
att, we will deprecate FbgemmConfig since it's a single kernel.
we'd like to categorize things to derived dtype + packed format

Test Plan:
python test/quantization/quantize_/test_int4_groupwise_preshuffle.py

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2474, branch: jerryzh168/stack/10
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/9 to main July 3, 2025 21:57
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/10 branch from acc33bd to 7412903 Compare July 3, 2025 21:57
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/9 July 3, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: new feature Use this tag if this PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants