Skip to content

[moe training] Add 2D parallel (FSDP2 + TP) tests for routed experts #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Jul 2, 2025

Stack

Summary

  • New integration test uses NGPU=4, with FDSP=2 and TP=2. Applies FSDP2 first, then applies TP.
  • Note all tests currently only apply float8 to routed experts, not shared experts.

Test plan

  • ./test/prototype/moe_training/test_fsdp_tp.sh

Copy link

pytorch-bot bot commented Jul 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2475

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit 80c88fc with merge base 6821971 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2025
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jul 2, 2025
@danielvegamyhre danielvegamyhre requested review from vkuzo and drisspg July 2, 2025 03:17
@@ -0,0 +1 @@
torchrun --nproc_per_node=4 --local-ranks-filter=0 -m pytest test/prototype/moe_training/test_fsdp_tp.py -s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at this point I'd also add test_everything.sh which runs all of the shell scripts, same as we do for float8 training

@danielvegamyhre
Copy link
Contributor Author

MPS test failure is unrelated to this change

@danielvegamyhre danielvegamyhre merged commit 2defe30 into main Jul 2, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants