(torchx/scheduler) Fill hostnames for each replica in slurm scheduler's describe API #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
d4l3k
requested changes
Jun 12, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Differential Revision: D76485112
facebook-github-bot
force-pushed
the
export-D76485112
branch
from
707637e to
b700e74
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
d4l3k
approved these changes
Jun 12, 2025
|
|
||
| return DescribeAppResponse( | ||
| app_id=app_id, | ||
| roles=list(roles.values()), | ||
| roles_statuses=list(roles_statuses.values()), | ||
| state=app_state, | ||
| msg=msg, |
There was a problem hiding this comment.
yea msg defaults to an empty string if not specified. We were just setting msg=state so no real functional value added + describe_sacct didn't set msg
kiukchung
added a commit
that referenced
this pull request
Jun 12, 2025
…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112
kiukchung
force-pushed
the
export-D76485112
branch
from
b700e74 to
6eca839
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112
facebook-github-bot
force-pushed
the
export-D76485112
branch
from
6eca839 to
3a3772c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
kiukchung
force-pushed
the
export-D76485112
branch
from
3a3772c to
d94f744
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
kiukchung
force-pushed
the
export-D76485112
branch
from
d94f744 to
256b6fe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
kiukchung
force-pushed
the
export-D76485112
branch
from
256b6fe to
8659984
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
kiukchung
force-pushed
the
export-D76485112
branch
from
8659984 to
ff1e48f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
kiukchung
force-pushed
the
export-D76485112
branch
from
ff1e48f to
0489983
Compare
facebook-github-bot
force-pushed
the
export-D76485112
branch
from
cf83fbd to
811a65f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112
facebook-github-bot
force-pushed
the
export-D76485112
branch
from
811a65f to
cc6ef31
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112
facebook-github-bot
force-pushed
the
export-D76485112
branch
from
cc6ef31 to
5e2fad7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112
facebook-github-bot
force-pushed
the
export-D76485112
branch
from
5e2fad7 to
923250a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112
facebook-github-bot
force-pushed
the
export-D76485112
branch
from
923250a to
bd24bf9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112
facebook-github-bot
force-pushed
the
export-D76485112
branch
from
bd24bf9 to
ba2ffea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76485112 |
facebook-github-bot
pushed a commit
to pytorch-labs/monarch
that referenced
this pull request
Jun 17, 2025
…ion and hostnames to mesh_spec Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Differential Revision: D76847192
facebook-github-bot
pushed a commit
to pytorch-labs/monarch
that referenced
this pull request
Jun 17, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Differential Revision: D76847192
kiukchung
added a commit
to pytorch-labs/monarch
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
kiukchung
added a commit
to pytorch-labs/monarch
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
kiukchung
added a commit
to pytorch-labs/monarch
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
kiukchung
added a commit
to pytorch-labs/monarch
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
kiukchung
added a commit
to pytorch-labs/monarch
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: Pull Request resolved: #296 TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
kiukchung
added a commit
to pytorch-labs/monarch
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: Pull Request resolved: #296 TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
facebook-github-bot
pushed a commit
to pytorch-labs/monarch
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
facebook-github-bot
pushed a commit
to pytorch-labs/monarch
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: Pull Request resolved: #296 TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192 fbshipit-source-id: 4d55083009ef9dd6ed46717fd375f5a49ee86a95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use
scontrolto implement the describe API that fills out the hostnames for each replica.Differential Revision: D76485112