This close #2146, support setting excel custom properties #2147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuri
added
the
size/L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2147 +/- ##
========================================
Coverage 99.23% 99.23%
========================================
Files 32 33 +1
Lines 30273 30393 +120
========================================
+ Hits 30042 30162 +120
Misses 153 153
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mengpromax
force-pushed
the
master
branch
2 times, most recently
from
edfc003 to
ab0b6f1
Compare
xuri
reviewed
Jun 1, 2025
xuri
requested changes
Jun 1, 2025
mengpromax
force-pushed
the
master
branch
6 times, most recently
from
2990830 to
e58fdbc
Compare
|
@xuri hi xuri, i have solved the comments, please take a look again. |
…erties in DocProps/custom.xml) - support save some biz k:v data to excel custom properties to do such that save excel biz version etc. Change-Id: I4a524b494f09fbfca321d515b5029f4f7361311f Signed-off-by: mengzhongyuan <[email protected]>
|
@xuri something else should i do before merging this to base? |
|
No action required, this PR has a lot of code, I need some time to review. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I4a524b494f09fbfca321d515b5029f4f7361311f
PR Details
support setting excel custom properties (actual file in DocProps/custom.xml) to save some biz info like biz version for further uses.
Description
Related Issue
#2146
Motivation and Context
I have a requirement that save some biz k:v data in the generated excel file, before i implent it my program wrote a hidden excel to save some such data.
How Has This Been Tested
Types of changes
Checklist