3.18 regression Quarkus quarkus-maven-plugin with failsafe and quarkus.test.arg-line

[michael-simons]

Describe the bug

I am using quarkus.test.arg-line to setup custom arg lines for integration tests running with failsafe:

See https://github.com/michael-simons/neo4j-migrations/blob/main/neo4j-migrations-quarkus-parent/integration-tests/pom.xml#L141

JaCoCo configures it to hold […]/target/jacoco.exec,append=true,includes=**/*, notice the commas.

Up to including Quarkus 3.17.7, this works fine, but starts failing in 3.18: https://github.com/michael-simons/neo4j-migrations/actions/runs/12987143055/job/36215407194?pr=1575#step:12:2957

Notice the lack of commas!

Also, the arg-line is actually duplicated, sort of.

Command that Quarkus 3.17.7 runs

java \
  -javaagent:/Users/msimons/.m2/repository/org/jacoco/org.jacoco.agent/0.8.12/org.jacoco.agent-0.8.12-runtime.jar=destfile=[..]/integration-tests/target/jacoco.exec,append=true,includes=**/* \
  -Dquarkus.http.port=8081 \
  -Dquarkus.http.ssl-port=8444 \
  -Dtest.url=http://localhost:8081 \
  -Dquarkus.log.file.path=/Users/msimons/Projects/michael-simons/neo4j-migrations/neo4j-migrations-quarkus-parent/integration-tests/target/quarkus.log \
  -Dquarkus.log.file.enable=true \
  -Dquarkus.log.category."io.quarkus".level=INFO \
  -Dquarkus.test.arg-line=-javaagent:/Users/msimons/.m2/repository/org/jacoco/org.jacoco.agent/0.8.12/org.jacoco.agent-0.8.12-runtime.jar=destfile=/Users/msimons/Projects/michael-simons/neo4j-migrations/neo4j-migrations-quarkus-parent/integration-tests/target/jacoco.exec,append=true,includes=**/* \
  -jar /Users/msimons/Projects/michael-simons/neo4j-migrations/neo4j-migrations-quarkus-parent/integration-tests/target/quarkus-app/quarkus-run.jar

Quarkus 3.18

java \
  -javaagent:/Users/msimons/.m2/repository/org/jacoco/org.jacoco.agent/0.8.12/org.jacoco.agent-0.8.12-runtime.jar=destfile=[..]/integration-tests/target/jacoco.exec append=true includes=**/* \
  -Dquarkus.http.port=8081 \
  -Dquarkus.http.ssl-port=8444 \
  -Dtest.url=http://localhost:8081 \
  -Dquarkus.log.file.path=/Users/msimons/Projects/michael-simons/neo4j-migrations/neo4j-migrations-quarkus-parent/integration-tests/target/quarkus.log \
  -Dquarkus.log.file.enable=true \
  -Dquarkus.log.category."io.quarkus".level=INFO \
  -Dquarkus.profile=prod \
  -Dquarkus.test.arg-line=-javaagent:/Users/msimons/.m2/repository/org/jacoco/org.jacoco.agent/0.8.12/org.jacoco.agent-0.8.12-runtime.jar=destfile=[..]/integration-tests/target/jacoco.exec,append=true,includes=**/* \
  -jar /Users/msimons/Projects/michael-simons/neo4j-migrations/neo4j-migrations-quarkus-parent/integration-tests/target/quarkus-app/quarkus-run.jar"

Do reproduce with above project:

git clone [email protected]:michael-simons/neo4j-migrations.git
cd neo4j-migrations
mvn -Dfast clean install
mvn clean verify -pl neo4j-migrations-quarkus-parent/integration-tests

Quarkus does a couple of odd things: It duplicates the quarkus.test.arg so that is passed to the original call to Java, and than as Quarkus property. I guess the latter can be omitted.
The former is that what breaks: Prior to 3.18, it just worked, now something replaces single , with blanks.
You can reproduce this without JaCoCo too, by just setting it to <quarkus.test.arg-line>asd,asd</quarkus.test.arg-line>,

Giving you something like this

Executing "/Users/msimons/.sdkman/candidates/java/21.0.5-zulu/zulu-21.jdk/Contents/Home/bin/java asd asd -Dquarkus.http.port=8081 -Dquarkus.http.ssl-port=8444 -Dtest.url=http://localhost:8081 -Dquarkus.log.file.path=/Users/msimons/Projects/michael-simons/neo4j-migrations/neo4j-migrations-quarkus-parent/integration-tests/target/quarkus.log -Dquarkus.log.file.enable=true -Dquarkus.log.category."io.quarkus".level=INFO -Dquarkus.profile=prod -Dquarkus.config.build-time-mismatch-at-runtime=fail -Dorg.neo4j.migrations.enabled=false -Dquarkus.test.arg-line=asd,asd -jar /Users/msimons/Projects/michael-simons/neo4j-migrations/neo4j-migrations-quarkus-parent/integration-tests/target/quarkus-app/quarkus-run.jar"

Output of uname -a or ver

24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 19:01:59 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T6000 arm64

Output of java -version

openjdk version "21.0.5" 2024-10-15 LTS
OpenJDK Runtime Environment Zulu21.38+21-CA (build 21.0.5+11-LTS)
OpenJDK 64-Bit Server VM Zulu21.38+21-CA (build 21.0.5+11-LTS, mixed mode, sharing)

Quarkus version or git rev

3.18.0

Build tool (ie. output of mvnw --version or gradlew --version)

Maven home: /Users/msimons/.m2/wrapper/dists/apache-maven-3.9.4-bin/32a55694/apache-maven-3.9.4
Java version: 21.0.5, vendor: Azul Systems, Inc., runtime: /Users/msimons/.sdkman/candidates/java/21.0.5-zulu/zulu-21.jdk/Contents/Home
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "15.2", arch: "aarch64", family: "Mac"

[quarkus-bot]

/cc @quarkusio/devtools (maven)

[gsmet]

Thanks for the detailed report, I will have a look soon.

[gsmet]

My bet is on #45100 . We used to consider arg line as a full string split with spaces and we now split it with commas first.

@radcortez I'm not sure how we can best fix this? Maybe we should have a specific list converter for quarkus.test.arg-line that splits on spaces instead of commas? Another option would be to consider this thing a String in the config and split it later.

I think it's something we need to fix before we officially ship 3.18 as it's going to be a problem for everyone using Jacoco.

[michael-simons]

Very welcome, thanks for taking care.

I am pretty sure it will happens if you follow https://quarkus.io/guides/tests-with-coverage in a less elaborate setup than my project, so I agree there's a good chance of a bigger blast radius.

[gsmet]

#45888 might fix it but I will let @radcortez decide if it needs a more involved fix.

[michael-simons]

Thank you! I can confirm this fixes my build 🙇

[gsmet]

Thanks for the confirmation. Glad we could catch this one before the official release!