Preserve Mockito's subclass behavior #31627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Mockito 5, the library has switched to using inline mocks by default. We almost certainly can support this, but it needs more investigation. For the time being it makes sense to preserve the mocking behavior users are used to since Quarkus 1.x Closes: quarkusio#31251
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
gsmet
approved these changes
Mar 6, 2023
|
thanks! |
|
🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Mockito 5, the library has switched to using inline mocks by default.
We almost certainly can support this, but it needs more investigation (one point for example
that jumps out from #31251 is that we need to see when it makes sense to clear inline mocks).
For the time being it makes sense to preserve the mocking behavior users are used to since Quarkus 1.x.
Closes: #31251