Skip to content

Fix split io.quarkus.elytron.security.runtime package by using own runtime package in Elytron Security Properties File extension #45886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

michalvavrik
Copy link
Member

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Hopefully, these elements are not consumed outside of Quarkus.

I think it's probably safe.

This comment has been minimized.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik @gsmet, indeed, it should be safe for these elements

Copy link

github-actions bot commented Jan 27, 2025

🎊 PR Preview f00a574 has been successfully built and deployed to https://quarkus-pr-main-45886-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

@sberyozkin
Copy link
Member

sberyozkin commented Jan 28, 2025

The changes do not seem to be related, but since the GraphQL ssl related tests are failing... May be it is a case of the expired keystore entries and they should be updated (separately from this PR) to use smallrye cert generation, CC @jmartisk ?

@jmartisk
Copy link
Contributor

The changes do not seem to be related, but since the GraphQL ssl related tests are failing... May be it is a case of the expired keystore entries and they should be updated (separately from this PR) to use smallrye cert generation, CC @jmartisk ?

They do use smallrye cert generation. The tests failed with java.net.BindException: Address already in use: bind, which suggests that there was something already listening on port 63805, which the tests are hardcoded to use to spin up a mock HTTP server. Weird, I haven't seen this before

@michalvavrik michalvavrik force-pushed the chore/elytron-fix-split-packages branch from 72ce6b7 to b39ecf1 Compare January 28, 2025 13:12
@michalvavrik
Copy link
Member Author

michalvavrik commented Jan 28, 2025

Windows failures can be debugged independently, so I rebased on the current main to see if we can get a green CI.

Copy link

quarkus-bot bot commented Jan 28, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b39ecf1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Jan 28, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b39ecf1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:57)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:57)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@gsmet gsmet merged commit 386eb40 into quarkusio:main Jan 28, 2025
28 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 28, 2025
@gsmet
Copy link
Member

gsmet commented Jan 28, 2025

Thanks!

@michalvavrik michalvavrik deleted the chore/elytron-fix-split-packages branch January 28, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io.quarkus.elytron.security.runtime is split across multiple modules
4 participants