-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix split io.quarkus.elytron.security.runtime
package by using own runtime package in Elytron Security Properties File extension
#45886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix split io.quarkus.elytron.security.runtime
package by using own runtime package in Elytron Security Properties File extension
#45886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Hopefully, these elements are not consumed outside of Quarkus.
I think it's probably safe.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michalvavrik @gsmet, indeed, it should be safe for these elements
🎊 PR Preview f00a574 has been successfully built and deployed to https://quarkus-pr-main-45886-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
The changes do not seem to be related, but since the GraphQL ssl related tests are failing... May be it is a case of the expired keystore entries and they should be updated (separately from this PR) to use smallrye cert generation, CC @jmartisk ? |
They do use smallrye cert generation. The tests failed with |
72ce6b7
to
b39ecf1
Compare
Windows failures can be debugged independently, so I rebased on the current main to see if we can get a green CI. |
Status for workflow
|
Status for workflow
|
Thanks! |
io.quarkus.elytron.security.runtime
is split across multiple modules #44725