Leave the TCCL how we found it after test discovery #47365

holly-cummins · 2025-04-14T22:15:46Z

Resolves #47081

The problem happened because at the end of test discovery, we leave the TCCL as the FacadeClassLoader. That classloader isn't really much use, outside the context of discovery, and it's actively unhelpful when other code is trying to evaluate JUnit conditions. The ideal TCCL for doing that is the system classloader.

We do have the option to listen to an event when discovery finishes, so I've hooked that event to reset the TCCL. For symmetry, I've also switched from intercepting the whole invocation to just hooking the discovery start.

My fix does not fix the continuous testing case; in that case, something in the runner is setting the TCCL to be the deployment classloader, which is still wrong for the condition execution code. I've committed a reproducer and raised #47364.

…radle maybe both work?

quarkus-bot · 2025-04-22T17:54:46Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit bfffe46.

Warning

Unable to include the stracktraces as the report was too long. See annotations below for the details.

Warning

Unable to include the failure links as the report was too long. See annotations below for the details.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Tests - JDK 21	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs	🔍
✖	Maven Tests - JDK 17	`Build`	Failures	Logs	Raw logs	🔍
✖	Maven Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs	🔍
✖	Gradle Tests - JDK 17	`Build`	Failures	Logs	Raw logs	🔍
✖	Gradle Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs	🔍
✖	MicroProfile TCKs Tests	`Verify`	Failures	Logs	Raw logs	🔍
✖	Native Tests - Build tools and DevTools	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Integration Tests - JDK 17	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Integration Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Integration Tests - JDK 21	`Build`	Failures	Logs	Raw logs	🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/vertx-http/deployment 
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 146 more

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.ChangeSourceAndTestAtOnceTestCase.testChangeSourceAndTestAtOnce line 40 - History

✖ io.quarkus.vertx.http.testrunner.QuarkusTestTypeTestCase.testQuarkusTestMode line 38 - History

✖ io.quarkus.vertx.http.testrunner.TestChangeTrackingWhenStartFailsTestCase.testChangeTrackingOnStartupFailure line 39 - History

✖ io.quarkus.vertx.http.testrunner.TestFailingBeforeAllTestCase.testBrokenBeforeAllHandling line 38 - History

✖ io.quarkus.vertx.http.testrunner.TestRunnerSmokeTestCase.checkTestsAreRun line 50 - History

✖ io.quarkus.vertx.http.testrunner.UnitTestTypeTestCase.testUnitMode line 38 - History

✖ io.quarkus.vertx.http.testrunner.brokenonly.TestBrokenOnlyTestCase.testBrokenOnlyMode line 44 - History

✖ io.quarkus.vertx.http.testrunner.includes.ExcludePatternTestCase.checkTestsAreRun line 41 - History

✖ io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun line 41 - History

✖ io.quarkus.vertx.http.testrunner.metaannotations.MetaAnnotationsTestCase.checkTestsAreRun line 40 - History

✖ io.quarkus.vertx.http.testrunner.params.TestParameterizedTestCase.testParameterizedTests line 44 - History

✖ io.quarkus.vertx.http.testrunner.tags.ExcludeTagsTestCase.checkTestsAreRun line 40 - History

✖ io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 40 - History

⚙️ JVM Tests - JDK 21 #

- Failing: extensions/vertx-http/deployment 
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 146 more