Panache and Hibernate Reactive use different Vert.x local contexts #47441
+232
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/dependencies
|
@DavideD it seems there are unrelated changes in this PR, correct? |
|
|
|
Nevermind, I rebased it and now this is the commit with the important changes: 3093299 |
tsegismont
reviewed
Apr 22, 2025
| if (current != null && current.isOpen()) { | ||
| return current; | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| private static <T> Map<Key<T>, T> contextualDataMap(ContextInternal vertxContext) { |
There was a problem hiding this comment.
Instead of duplicating this method here, we could make it public in Hibernate Reactive and keep the ContextualDataStorage.CONTEXTUAL_DATA_KEY private.
By doing so, the implementation details about how the ConcurrentMap is created/retrieved remains hidden, yet the consumers can manipulate the data it holds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #47314
Draft because it needs these changes in Hibernate Reactive (next release).
@tsegismont, or @vietj, Do these changes make sense?
Thanks