Skip to content

Fail build when multiple HttpSecurityPolicies with same name are detected #47448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

This comment has been minimized.

@michalvavrik
Copy link
Member Author

It is pitty, but I think both failures are expected. The integration-tests/observability-lgtm failure I have seen in my other PR (step up auth) which is entirely unrelated to this one. And integration-tests/oidc-wiremock-logout fails due to #47396.

@michalvavrik michalvavrik force-pushed the feature/add-http-sec-policy-validation branch from ecebbcf to 85975e7 Compare April 20, 2025 07:45
@michalvavrik
Copy link
Member Author

Rebased on current main.

Copy link

quarkus-bot bot commented Apr 20, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 85975e7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-6","-7","-9","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-6","-7","-9","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed(MicrometerTimedInterceptorTest.java:150)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)

@sberyozkin sberyozkin merged commit 63962a0 into quarkusio:main Apr 20, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.23 - main milestone Apr 20, 2025
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Apr 20, 2025
@michalvavrik michalvavrik deleted the feature/add-http-sec-policy-validation branch April 20, 2025 10:04
@gsmet gsmet modified the milestones: 3.23 - main, 3.22.0 Apr 22, 2025
@gsmet gsmet modified the milestones: 3.22.0, 3.21.4 Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempt to create HttpSecurityPolicy with duplicated names should lead to warning or error
3 participants