Skip to content

Set correct default values in constructors of OIDC config builders #47451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

michalvavrik
Copy link
Member

Copy link

quarkus-bot bot commented Apr 20, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8d11c39.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

Copy link

quarkus-bot bot commented Apr 20, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 8d11c39.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

🎊 PR Preview 63962a0 has been successfully built and deployed to https://quarkus-pr-main-47451-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@sberyozkin
Copy link
Member

Hi @michalvavrik This looks quite neat, my primitive idea was to go and set those properties manually :-).
I believe we need the same for various OidcTenantConfig builders too

@michalvavrik
Copy link
Member Author

I believe we need the same for various OidcTenantConfig builders too

that is already done, I had this idea before, just didn't apply it on client/client-reg/common

@sberyozkin sberyozkin merged commit 71c9959 into quarkusio:main Apr 21, 2025
30 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.23 - main milestone Apr 21, 2025
@michalvavrik michalvavrik deleted the feature/always-populate-oidc-builders-with-defaults branch April 21, 2025 21:55
@gsmet gsmet modified the milestones: 3.23 - main, 3.22.0 Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default constructors of OIDC config builders should set correct default values
3 participants