Skip to content

Avoid setting null system properties in Mojos #47472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 22, 2025

Empty values injected by @parameter in a Map are going to be null. We should avoid trying to push these values to the system properties as they are ultimately backed by a CHM, which doesn't support null values.

Fixes #47446

Empty values injected by @parameter in a Map are going to be null.
We should avoid trying to push these values to the system properties as
they are ultimately backed by a CHM, which doesn't support null values.

Fixes quarkusio#47446
@gsmet gsmet requested a review from aloubyansky April 22, 2025 08:56
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Apr 22, 2025
Copy link

quarkus-bot bot commented Apr 22, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 0e6d972.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 8aceae3 into quarkusio:main Apr 22, 2025
56 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.23 - main milestone Apr 22, 2025
@gsmet gsmet modified the milestones: 3.23 - main, 3.22.0 Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE in mvn quarkus:build (BuildMojo.doExecute)
2 participants