Skip to content

Use dev services instead of maven docker plugin for Hibernate Search tests #48512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marko-bekhta
Copy link
Contributor

@quarkus-bot quarkus-bot bot added the area/hibernate-search Hibernate Search label Jun 20, 2025
Copy link

quarkus-bot bot commented Jun 20, 2025

/cc @gsmet (hibernate-search)

Copy link

🎊 PR Preview bed5ce2 has been successfully built and deployed to https://quarkus-pr-main-48512-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you are aware of that but the tests have to be disabled if you don't have -Dtest-containers set. And I think you dropped that?

Two reasons:

  • we don't want to make Docker absolutely necessary to build Quarkus
  • and indeed running containers is not supported on Windows on GitHub Actions - so any test using a container has to be disabled (and we don't pass -Dtest-containers)

@marko-bekhta
Copy link
Contributor Author

Got it 🙂, yes I wasn't sure how usually one would skip some modules, so I just assumed the -DskipTests 🙈

I'll clean it up to make it all work as before with the property. But .. do you think that in general it makes sense to do this switch ? I saw that issue that Holly opened and since I noticed the mix of dev services + maven docker plugin I thought I'd give this idea to unify containers use a try.. but then I might just be missing something 🙂 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-search Hibernate Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants